Adding support for Kubernetes ISOs#36
Merged
Merged
Conversation
Contributor
Author
|
Requires apache/cloudstack-go#39 |
davidjumani
force-pushed
the
add-cks-versions
branch
5 times, most recently
from
db9d4f1 to
7ddf099
Compare
davidjumani
force-pushed
the
add-cks-versions
branch
from
7ddf099 to
4510059
Compare
harikrishna-patnala
approved these changes
Jun 13, 2022
harikrishna-patnala
left a comment
harikrishna-patnala
left a comment
Member
There was a problem hiding this comment.
Tested the kubernetes version APIs create, update (the "state" parameter) and destroy. Working as expected.
LGTM
|
@davidjumani very good stuff 👍 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for Kubernetes ISOs
Contains the following actions :